Add UMA actions for elements on the Hung Renderer Dialog

chrome/browser/ui/views/hung_renderer_view.cc

Index: chrome/browser/ui/views/hung_renderer_view.cc
diff --git a/chrome/browser/ui/views/hung_renderer_view.cc b/chrome/browser/ui/views/hung_renderer_view.cc
index 5d2503c9bd33a081035fbe228e8d2a0cb34ca187..201ae8d4b808981ac28988b8832a4b18411e353f 100644
--- a/chrome/browser/ui/views/hung_renderer_view.cc
+++ b/chrome/browser/ui/views/hung_renderer_view.cc
@@ -20,6 +20,7 @@
 #include "components/web_modal/web_contents_modal_dialog_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
+#include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/result_codes.h"
 #include "grit/theme_resources.h"
@@ -43,6 +44,7 @@
 #include "ui/views/win/hwnd_util.h"
 #endif
 
+using base::UserMetricsAction;
 using content::WebContents;
 
 HungRendererDialogView* HungRendererDialogView::g_instance_ = NULL;
@@ -283,6 +285,7 @@ void HungRendererDialogView::ShowForWebContents(WebContents* contents) {
     // one is showing.
     hung_pages_table_model_->InitForWebContents(contents);
     GetWidget()->Show();
+    content::RecordAction(UserMetricsAction("HungRendererDialogView.Shown"));

[msw, 2015/01/02 22:58:35]

Should this be outside of the active Widget check? (Do you want to record this
metric if the dialog is triggered while it's already open, perhaps if a second
tab is hung?)

Further, should this be before the early return at the top of the function? (Do
you want to record this metric if the dialog is stifled because the browser
window isn't active when the hang is detected?)

At the most extreme, should this be recorded even earlier in
HungRendererDialogView::Show(), if there is no root window or if
logging::DialogsAreSuppressed()?

I'm not so sure that recording the number of times the dialog is shown (at least
like this) will correlate strongly with the number of detected page
hangs/crashes reported through other mechanisms...

   }
 }
 
@@ -292,6 +295,7 @@ void HungRendererDialogView::EndForWebContents(WebContents* contents) {
       hung_pages_table_model_->GetRenderProcessHost() ==
       contents->GetRenderProcessHost()) {
     GetWidget()->Close();
+    content::RecordAction(UserMetricsAction("HungRendererDialogView.Closed"));

[msw, 2015/01/02 22:58:35]

Should this also be recorded in HungRendererDialogView::TabDestroyed()?
Perhaps override DialogDelegate::OnClosed() to record this instead?

     // Close is async, make sure we drop our references to the tab immediately
     // (it may be going away).
     hung_pages_table_model_->InitForWebContents(NULL);
@@ -338,12 +342,18 @@ views::View* HungRendererDialogView::CreateExtraView() {
 bool HungRendererDialogView::Accept(bool window_closing) {
   // Don't do anything if we're being called only because the dialog is being
   // destroyed and we don't supply a Cancel function...
-  if (window_closing)
+  if (window_closing) {
+    content::RecordAction(
+        UserMetricsAction("HungRendererDialogView.CloseButton"));
     return true;
+  }
 
   // Start waiting again for responsiveness.
-  if (hung_pages_table_model_->GetRenderViewHost())
+  if (hung_pages_table_model_->GetRenderViewHost()) {
+    content::RecordAction(
+        UserMetricsAction("HungRendererDialogView.WaitButton"));
     hung_pages_table_model_->GetRenderViewHost()->RestartHangMonitorTimeout();
+  }
   return true;
 }
 
@@ -365,6 +375,8 @@ void HungRendererDialogView::ButtonPressed(
     views::Button* sender, const ui::Event& event) {
   if (sender == kill_button_ &&
       hung_pages_table_model_->GetRenderProcessHost()) {
+    content::RecordAction(
+        UserMetricsAction("HungRendererDialogView.KillButton"));
     KillRendererProcess(hung_pages_table_model_->GetRenderProcessHost());
   }
 }