Add InlinedMarkingVisitor::shouldMarkObject() predicate.

Add InlinedMarkingVisitor::shouldMarkObject() predicate.

Rename checkSkipForObjectInTerminatingThreadHeap() as shouldMarkObject()
and invert the predicate's meaning: it returns true if the object reference
should be marked and traced, false if it should not be.

When performing a thread-local GC, references to other thread heaps should
not be marked and traced.

R=haraken
BUG=445388
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187774

[sof, 2014-12-29 21:23:52]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2014-12-29 21:23:53]

Please take a look.

[haraken, 2014-12-30 02:07:13]

LGTM

Can we add a test for this?

[haraken, 2014-12-30 02:52:49]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2014-12-30 02:52:50]

https://codereview.chromium.org/818923005/diff/1/Source/platform/heap/Heap.cpp
File Source/platform/heap/Heap.cpp (right):

https://codereview.chromium.org/818923005/diff/1/Source/platform/heap/Heap.cp...
Source/platform/heap/Heap.cpp:2131: inline bool
checkSkipForObjectInTerminatingThreadHeap(const void* objectPointer)

For clarity, shall we rename this method to shouldTraceObject() (just like you
proposed before) and invert the return value? The caller site should be:

  if (!shouldTraceObject(object))
    return;

[sof, 2014-12-30 08:52:31]

On 2014/12/30 02:07:13, haraken wrote:
> LGTM
> 
> Can we add a test for this?

Yes, a fun exercise it turned out to be.

[sof, 2014-12-30 08:52:40]

https://codereview.chromium.org/818923005/diff/1/Source/platform/heap/Heap.cpp
File Source/platform/heap/Heap.cpp (right):

https://codereview.chromium.org/818923005/diff/1/Source/platform/heap/Heap.cp...
Source/platform/heap/Heap.cpp:2131: inline bool
checkSkipForObjectInTerminatingThreadHeap(const void* objectPointer)
On 2014/12/30 02:52:50, haraken wrote:
> 
> For clarity, shall we rename this method to shouldTraceObject() (just like you
> proposed before) and invert the return value? The caller site should be:
> 
>   if (!shouldTraceObject(object))
>     return;

Agreed; shouldMarkObject() is more precise now & went with that.

[sof, 2014-12-30 09:04:05]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-12-30 09:05:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818923005/40001

[commit-bot: I haz the power, 2014-12-30 10:28:52]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187774

[kouhei (in TOK), 2015-01-05 00:49:38]

lgtm Thanks for the fix.