Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2582)

Unified Diff: Source/platform/heap/MarkingVisitorImpl.h

Issue 818923005: Add InlinedMarkingVisitor::shouldMarkObject() predicate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update predicate Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/InlinedGlobalMarkingVisitor.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/MarkingVisitorImpl.h
diff --git a/Source/platform/heap/MarkingVisitorImpl.h b/Source/platform/heap/MarkingVisitorImpl.h
index 7e2f5133a9766a87a198e2425093ebf016def19f..4e14ba1dfd7f6291cd560b929fc91053895c50c3 100644
--- a/Source/platform/heap/MarkingVisitorImpl.h
+++ b/Source/platform/heap/MarkingVisitorImpl.h
@@ -31,7 +31,7 @@ protected:
// when called within.
ASSERT(!ThreadState::current()->isInGC() || Heap::containedInHeapOrOrphanedPage(header));
- if (toDerived()->checkSkipForObjectInTerminatingThreadHeap(objectPointer))
+ if (!toDerived()->shouldMarkObject(objectPointer))
return;
// If you hit this ASSERT, it means that there is a dangling pointer
@@ -93,7 +93,7 @@ protected:
{
if (!objectPointer)
return false;
- if (toDerived()->checkSkipForObjectInTerminatingThreadHeap(objectPointer))
+ if (!toDerived()->shouldMarkObject(objectPointer))
return false;
#if ENABLE(ASSERT)
if (isMarked(objectPointer))
@@ -117,7 +117,7 @@ protected:
{ \
if (!objectPointer) \
return false; \
- if (toDerived()->checkSkipForObjectInTerminatingThreadHeap(objectPointer)) \
+ if (!toDerived()->shouldMarkObject(objectPointer)) \
return false; \
if (isMarked(objectPointer)) \
return false; \
@@ -130,7 +130,7 @@ protected:
{ \
if (!objectPointer) \
return false; \
- if (toDerived()->checkSkipForObjectInTerminatingThreadHeap(objectPointer)) \
+ if (!toDerived()->shouldMarkObject(objectPointer)) \
return false; \
HeapObjectHeader* header = HeapObjectHeader::fromPayload(objectPointer); \
if (header->isMarked()) \
« no previous file with comments | « Source/platform/heap/InlinedGlobalMarkingVisitor.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698