Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2043)

Unified Diff: Source/platform/heap/Heap.cpp

Issue 818923005: Add InlinedMarkingVisitor::shouldMarkObject() predicate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: update predicate Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/platform/heap/HeapTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Heap.cpp
diff --git a/Source/platform/heap/Heap.cpp b/Source/platform/heap/Heap.cpp
index 0d332a9264998e5f3309e85e53b23a6b6478a6c7..779a9be65f7fce0658dea8eca219c35a76e7124f 100644
--- a/Source/platform/heap/Heap.cpp
+++ b/Source/platform/heap/Heap.cpp
@@ -2128,16 +2128,16 @@ protected:
Impl::registerWeakCellWithCallback(cell, callback);
}
- inline bool checkSkipForObjectInTerminatingThreadHeap(const void* objectPointer)
+ inline bool shouldMarkObject(const void* objectPointer)
{
if (Mode != ThreadLocalMarking)
- return false;
+ return true;
BaseHeapPage* page = pageFromObject(objectPointer);
ASSERT(!page->orphaned());
// When doing a thread local GC, the marker checks if
- // the object resides in another thread's heap. The
- // object should not be traced, if it does.
+ // the object resides in another thread's heap. If it
+ // does, the object should not be marked & traced.
return page->terminating();
}
};
« no previous file with comments | « no previous file | Source/platform/heap/HeapTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698