fix a few linux compilation warnings

fix a few linux compilation warnings

BUG=https://code.google.com/p/pdfium/issues/detail?id=102

[Tom Sepez, 2015-01-15 19:32:05]

tsepez@chromium.org changed reviewers:
+ bo_xu@foxitsoftware.com, jun_fang@foxitsoftware.com

[Tom Sepez, 2015-01-15 19:32:05]

Jun, please have foxit developers look over this list of changes.  In
particular, the items marked with TODO(tsepez) are likely real issues that need
careful consideration rather than simply deleting the unused lines.

[jun_fang, 2015-01-15 19:36:22]

On 2015/01/15 19:32:05, Tom Sepez wrote:
> Jun, please have foxit developers look over this list of changes.  In
> particular, the items marked with TODO(tsepez) are likely real issues that
need
> careful consideration rather than simply deleting the unused lines.

Sure. We will check the code change carefully.

[brucedawson, 2015-01-15 22:18:10]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2015-01-15 22:18:10]

Consider also disabling the warning about missing initializer, to further reduce
the noise.

https://codereview.chromium.org/818363006/diff/1/core/src/fxcodec/lcms2/lcms2...
File core/src/fxcodec/lcms2/lcms2-2.6/src/cmslut.c (right):

https://codereview.chromium.org/818363006/diff/1/core/src/fxcodec/lcms2/lcms2...
core/src/fxcodec/lcms2/lcms2-2.6/src/cmslut.c:1282: cmsFloat32Number
Storage[2][MAX_STAGE_CHANNELS] = { {0.0f}, {0.0f} };
This could also be written as:

cmsFloat32Number Storage[2][MAX_STAGE_CHANNELS] = {};

This requests zero initialization of everything and feels cleaner to me. The
current code suggests that MAX_STAGE_CHANNELS is one, which actually feels
misleading.

https://codereview.chromium.org/818363006/diff/1/core/src/fxcodec/lcms2/lcms2...
core/src/fxcodec/lcms2/lcms2-2.6/src/cmslut.c:1308: cmsFloat32Number
Storage[2][MAX_STAGE_CHANNELS] = { {0.0f}, {0.0f} };
See above.

[Tom Sepez, 2015-01-16 19:23:04]

https://codereview.chromium.org/818363006/diff/1/core/src/fxcodec/lcms2/lcms2...
File core/src/fxcodec/lcms2/lcms2-2.6/src/cmslut.c (right):

https://codereview.chromium.org/818363006/diff/1/core/src/fxcodec/lcms2/lcms2...
core/src/fxcodec/lcms2/lcms2-2.6/src/cmslut.c:1282: cmsFloat32Number
Storage[2][MAX_STAGE_CHANNELS] = { {0.0f}, {0.0f} };
On 2015/01/15 22:18:10, brucedawson wrote:
> This could also be written as:
> 
> cmsFloat32Number Storage[2][MAX_STAGE_CHANNELS] = {};
> 
> This requests zero initialization of everything and feels cleaner to me. The
> current code suggests that MAX_STAGE_CHANNELS is one, which actually feels
> misleading.
Actually, this is a "third party" file that I'm going to leave unchanged and
just kill the warning.

[brucedawson, 2015-01-16 20:26:47]

Okay, sounds reasonable.

lgtm, once the questions raised by the comments you added are
resolved/investigated by the Foxit team.

[jun_fang, 2015-01-16 22:07:59]

I am still reviewing the code change. May provide more comments later.

https://codereview.chromium.org/818363006/diff/1/core/src/fpdfapi/fpdf_parser...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp (right):

https://codereview.chromium.org/818363006/diff/1/core/src/fpdfapi/fpdf_parser...
core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp:241: // TODO(tsepez):
bEarlyChange not use, also BPC vs. bits per component?
We think that bEarlyChange can be removed. The history is lost and we just guess
it shall be updated but not when code was changed for fixing bugs in this
function. bpc and BitsPerComponen are still used.

https://codereview.chromium.org/818363006/diff/1/core/src/fpdfapi/fpdf_parser...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right):

https://codereview.chromium.org/818363006/diff/1/core/src/fpdfapi/fpdf_parser...
core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:1018:
m_pFile->ReadBlock(srcBuf, offset, actualSize);
You are right. m_pFile shall be replaced with pFile.

[jun_fang, 2015-01-17 00:39:18]

More comments.

https://codereview.chromium.org/818363006/diff/20001/core/src/fxge/dib/fx_dib...
File core/src/fxge/dib/fx_dib_composite.cpp (right):

https://codereview.chromium.org/818363006/diff/20001/core/src/fxge/dib/fx_dib...
core/src/fxge/dib/fx_dib_composite.cpp:4153: FX_BOOL bCmyk = FALSE;
One of bRgb and bCmyk is duplicated. Suggest to remove bRgb but keep bCmyk. It
needs to be updated at line 4171 too.

https://codereview.chromium.org/818363006/diff/20001/core/src/fxge/ge/fx_ge_f...
File core/src/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/818363006/diff/20001/core/src/fxge/ge/fx_ge_f...
core/src/fxge/ge/fx_ge_fontmap.cpp:1378: size_t readCnt = FXSYS_fread(buffer,
12, 1, pFile);
suggest to check whether readCnt equals to 12.

https://codereview.chromium.org/818363006/diff/20001/core/src/fxge/ge/fx_ge_l...
File core/src/fxge/ge/fx_ge_linux.cpp (right):

https://codereview.chromium.org/818363006/diff/20001/core/src/fxge/ge/fx_ge_l...
core/src/fxge/ge/fx_ge_linux.cpp:167: if ((style & FXFONT_ITALIC) == bItalic) {
it shall be changed to if ((style & FXFONT_ITALIC) && bItalic)

[Tom Sepez, 2015-10-08 20:26:23]

Closing without landing; this is stale and overtaken by other cls.