core/src/fxge/dib/fx_dib_composite.cpp - Issue 818363006: fix a few linux compilation warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/dib/fx_dib_composite.cpp

Issue 818363006: fix a few linux compilation warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Restore origina cmslut.c Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/dib/fx_dib_composite.cpp

diff --git a/core/src/fxge/dib/fx_dib_composite.cpp b/core/src/fxge/dib/fx_dib_composite.cpp

index 375b7c110e82b23428b51d7aaac985ccd8822f02..4558e1287a2ee3508324f2ba13c382f976b11cfc 100644

--- a/core/src/fxge/dib/fx_dib_composite.cpp

+++ b/core/src/fxge/dib/fx_dib_composite.cpp

@@ -4149,6 +4149,7 @@ FX_BOOL CFX_DIBitmap::CompositeBitmap(int dest_left, int dest_top, int width, in

int dest_Bpp = m_bpp / 8;

int src_Bpp = pSrcBitmap->GetBPP() / 8;

FX_BOOL bRgb = FALSE;

+ // TODO(tsepez): Unused bCymk warning here is troubling. Is CMYK supported properly?

FX_BOOL bCmyk = FALSE;

jun_fang 2015/01/17 00:39:17 One of bRgb and bCmyk is duplicated. Suggest to re

if (src_Bpp > 1) {

if (pSrcBitmap->IsCmykImage()) {