core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp - Issue 818363006: fix a few linux compilation warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

Issue 818363006: fix a few linux compilation warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Restore origina cmslut.c Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

index c477ba6f6e2015e0516bcb803f025d94ab97e167..a85a1d3d82b312e795b61a476eb151ffa0153f72 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp

@@ -994,6 +994,7 @@ FX_BOOL CPDF_Stream::Identical(CPDF_Stream* pOther) const

return TRUE;

}

if (m_GenNum != (FX_DWORD) - 1 || pOther->m_GenNum != (FX_DWORD) - 1) {

+ // TODO(tsepez); unused pFile is probably a bug below.

IFX_FileRead* pFile = NULL;

FX_LPBYTE pBuf = NULL;

FX_DWORD offset = 0;