Stop creating GrODS for stencilPath commands.

Stop creating GrODS for stencilPath commands.

Committed: https://skia.googlesource.com/skia/+/3e79124a69d4806f0a1a776090bff718e1b90970

[bsalomon, 2014-12-17 19:00:21]

bsalomon@google.com changed reviewers:
+ joshualitt@google.com

[bsalomon, 2014-12-17 19:00:22]

Doesn't go all the way to not using GrDrawState for stencilPath at the
GrDrawTarget level, but rather just removes the need to convert it to GrODS
before sending to GrGpu. To remove the GrDrawState will require some work on
clip mask mananger.

[bsalomon, 2014-12-17 19:07:43]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-12-17 19:08:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/816513003/20001

[commit-bot: I haz the power, 2014-12-17 19:08:16]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-12-18 01:08 UTC

[commit-bot: I haz the power, 2014-12-17 19:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 19:09:46]

Try jobs failed on following builders:
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Cl...)
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile
(http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GC...)

[bsalomon, 2014-12-17 21:14:14]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2014-12-17 21:14:19]

ping

[commit-bot: I haz the power, 2014-12-17 21:14:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/816513003/60001

[commit-bot: I haz the power, 2014-12-17 21:14:56]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-12-18 03:14 UTC

[joshualitt, 2014-12-17 21:22:37]

https://codereview.chromium.org/816513003/diff/60001/src/gpu/GrInOrderDrawBuf...
File src/gpu/GrInOrderDrawBuffer.cpp (right):

https://codereview.chromium.org/816513003/diff/60001/src/gpu/GrInOrderDrawBuf...
src/gpu/GrInOrderDrawBuffer.cpp:444: 
Is there any reason StencilPathCmd doesn't just hold onto a
GrGpu::StencilPathState?

[bsalomon, 2014-12-17 21:34:08]

On 2014/12/17 21:22:37, joshualitt wrote:
>
https://codereview.chromium.org/816513003/diff/60001/src/gpu/GrInOrderDrawBuf...
> File src/gpu/GrInOrderDrawBuffer.cpp (right):
> 
>
https://codereview.chromium.org/816513003/diff/60001/src/gpu/GrInOrderDrawBuf...
> src/gpu/GrInOrderDrawBuffer.cpp:444: 
> Is there any reason StencilPathCmd doesn't just hold onto a
> GrGpu::StencilPathState?

It points to stack variables, StencilPathCmd has to make a copy.

[joshualitt, 2014-12-17 21:42:01]

lgtm

[commit-bot: I haz the power, 2014-12-17 21:43:17]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3e79124a69d4806f0a1a776090bff718e1b90970