Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 8159006: Move kExtensionScheme from content to chrome (Closed)

Created:
9 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 2 months ago
CC:
chromium-reviews, dpranke+watch-content_chromium.org, jam, Erik does not do reviews, Paweł Hajdan Jr., yoshiki+watch_chromium.org, mihaip+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move kExtensionScheme from content to chrome BUG=89642 TEST=everything still works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104492

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : updates #

Patch Set 4 : revert to old version #

Patch Set 5 : use string_util #

Patch Set 6 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -34 lines) Patch
M chrome/browser/extensions/extension_data_deleter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_render_view_host_observer.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/url_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_context_set.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/save_package.cc View 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/url_constants.h View 1 2 3 3 chunks +10 lines, -3 lines 0 comments Download
M content/common/url_constants.cc View 1 2 3 4 5 3 chunks +50 lines, -12 lines 0 comments Download
M content/renderer/render_view.cc View 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
John, please review Randy, fyi I'll drop the render_view_host.cc change from the CL, it's just ...
9 years, 2 months ago (2011-10-05 23:08:47 UTC) #1
jam
lgtm
9 years, 2 months ago (2011-10-06 05:41:30 UTC) #2
jochen (gone - plz use gerrit)
On 2011/10/06 05:41:30, John Abd-El-Malek wrote: > lgtm John, I've wrapped the savable schemes in ...
9 years, 2 months ago (2011-10-06 14:07:34 UTC) #3
jam
ok but why do you care about saving memory at shutdown? we want shutdown to ...
9 years, 2 months ago (2011-10-06 17:51:43 UTC) #4
jochen (gone - plz use gerrit)
On 2011/10/06 17:51:43, John Abd-El-Malek wrote: > ok > > but why do you care ...
9 years, 2 months ago (2011-10-06 18:19:40 UTC) #5
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8159006/9006
9 years, 2 months ago (2011-10-06 18:39:37 UTC) #6
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8159006/6016
9 years, 2 months ago (2011-10-06 19:21:44 UTC) #7
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8159006/7018
9 years, 2 months ago (2011-10-06 19:39:27 UTC) #8
commit-bot: I haz the power
9 years, 2 months ago (2011-10-06 21:22:38 UTC) #9
Can't apply patch for file chrome/renderer/extensions/chrome_v8_context_set.cc.
While running patch -p1 --forward --force;
patching file chrome/renderer/extensions/chrome_v8_context_set.cc
Hunk #1 FAILED at 7.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/renderer/extensions/chrome_v8_context_set.cc.rej

Powered by Google App Engine
This is Rietveld 408576698