Move check whether desktop notifications can be shown to browser

Move check whether desktop notifications can be shown to browser

BUG=89642
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104262

[jochen (gone - plz use gerrit), 2011-10-05 11:10:46]

plz review

[jam, 2011-10-05 17:26:41]

seems like all embedders would want to disallow javascript? moving this logic
out to chrome means that embedders somehow have to know to do this, which seems
easy to miss.

can we just blacklist schemes in content?

[jochen (gone - plz use gerrit), 2011-10-05 19:12:50]

On 2011/10/05 17:26:41, John Abd-El-Malek wrote:
> seems like all embedders would want to disallow javascript? moving this logic
> out to chrome means that embedders somehow have to know to do this, which
seems
> easy to miss.
> 
> can we just blacklist schemes in content?

like this?

[jam, 2011-10-05 19:18:07]

why is the change in chrome needed? i realize it also checks for extensions, but
it seems it would only exist because the check in content isn't strong enough.

might be good to also check with whoever wrote that code

[jochen (gone - plz use gerrit), 2011-10-05 20:03:30]

Hey Drew, hey Dmitry,

can one of you review this?

I've chatted with John and he said blocking javascript and file should
essentially be enough, but suggested one of you guys reviews this

[jam, 2011-10-05 20:13:35]

On Wed, Oct 5, 2011 at 1:03 PM, <jochen@chromium.org> wrote:

> Hey Drew, hey Dmitry,
>
> can one of you review this?
>
> I've chatted with John and he said blocking javascript and file should
> essentially be enough, but suggested one of you guys reviews this
>

just to be clear, I said that based on the comment, it looks like just
checking against JS should be enough. I defer to people more familiar with
this.

>
>
http://codereview.chromium.**org/8135028/<http://codereview.chromium.org/8135...
>

[jochen (gone - plz use gerrit), 2011-10-05 20:16:21]

On 2011/10/05 20:13:35, John Abd-El-Malek wrote:
> On Wed, Oct 5, 2011 at 1:03 PM, <mailto:jochen@chromium.org> wrote:
> 
> > Hey Drew, hey Dmitry,
> >
> > can one of you review this?
> >
> > I've chatted with John and he said blocking javascript and file should
> > essentially be enough, but suggested one of you guys reviews this
> >
> 
> just to be clear, I said that based on the comment, it looks like just
> checking against JS should be enough. I defer to people more familiar with
> this.

sorry for the confusion. I chated with John Greg who originally wrote this code
> 
> >
> >
>
http://codereview.chromium.**org/8135028/%3Chttp://codereview.chromium.org/81...>
> >

[jam, 2011-10-05 20:24:57]

On Wed, Oct 5, 2011 at 1:16 PM, <jochen@chromium.org> wrote:

> On 2011/10/05 20:13:35, John Abd-El-Malek wrote:
>
>  On Wed, Oct 5, 2011 at 1:03 PM, <mailto:jochen@chromium.org> wrote:
>>
>
>  > Hey Drew, hey Dmitry,
>> >
>> > can one of you review this?
>> >
>> > I've chatted with John and he said blocking javascript and file should
>> > essentially be enough, but suggested one of you guys reviews this
>> >
>>
>
>  just to be clear, I said that based on the comment, it looks like just
>> checking against JS should be enough. I defer to people more familiar with
>> this.
>>
>
> sorry for the confusion. I chated with John Greg who originally wrote this
> code
>

ah ok nm :)

>
>  >
>> >
>>
>
> http://codereview.chromium.****org/8135028/%3Chttp://coderevi**
> ew.chromium.org/8135028/ <http://codereview.chromium.org/8135028/>>
>
>> >
>>
>
>
>
>
http://codereview.chromium.**org/8135028/<http://codereview.chromium.org/8135...
>

[Dmitry Titov, 2011-10-05 20:34:27]

LGTM.
I wish there would be a check for allow-file-access-from-files switch, but since
it's not in the original code, it's ok.

[jam, 2011-10-06 06:07:34]

lgtm

[commit-bot: I haz the power, 2011-10-06 06:13:42]

CQ is trying the patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/8135028/6001

[commit-bot: I haz the power, 2011-10-06 08:22:59]

Change committed as 104262