Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 815143002: Use weak cells in CheckPropertyCell. (Closed)

Created:
6 years ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use weak cells in CheckPropertyCell. BUG=v8:3629 LOG=N Committed: https://crrev.com/81c4a42221b209c4e430584b1a2528f091a5ae32 Cr-Commit-Position: refs/heads/master@{#26379}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -23 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 1 chunk +5 lines, -8 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ulan
PTAL
5 years, 10 months ago (2015-01-30 14:58:14 UTC) #2
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-02 12:08:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/815143002/20001
5 years, 10 months ago (2015-02-02 12:11:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-02 12:47:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 12:48:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81c4a42221b209c4e430584b1a2528f091a5ae32
Cr-Commit-Position: refs/heads/master@{#26379}

Powered by Google App Engine
This is Rietveld 408576698