src/ic/mips/handler-compiler-mips.cc - Issue 815143002: Use weak cells in CheckPropertyCell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/mips/handler-compiler-mips.cc

Issue 815143002: Use weak cells in CheckPropertyCell. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/mips/handler-compiler-mips.cc

diff --git a/src/ic/mips/handler-compiler-mips.cc b/src/ic/mips/handler-compiler-mips.cc

index ba81dfe3a05b82320305e9adee4f1454b20e90dd..b429e8aef3396e84637a1f512076ef6dddfb92f5 100644

--- a/src/ic/mips/handler-compiler-mips.cc

+++ b/src/ic/mips/handler-compiler-mips.cc

@@ -197,7 +197,8 @@ void PropertyHandlerCompiler::GenerateCheckPropertyCell(

Handle<Cell> cell = JSGlobalObject::EnsurePropertyCell(global, name);

DCHECK(cell->value()->IsTheHole());

- __ li(scratch, Operand(cell));

+ Handle<WeakCell> weak_cell = masm->isolate()->factory()->NewWeakCell(cell);

+ __ LoadWeakValue(scratch, weak_cell, miss);

__ lw(scratch, FieldMemOperand(scratch, Cell::kValueOffset));

__ LoadRoot(at, Heap::kTheHoleValueRootIndex);

__ Branch(miss, ne, scratch, Operand(at));

« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »