Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 815143002: Use weak cells in CheckPropertyCell. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 190
191 191
192 // Generate code to check that a global property cell is empty. Create 192 // Generate code to check that a global property cell is empty. Create
193 // the property cell at compilation time if no cell exists for the 193 // the property cell at compilation time if no cell exists for the
194 // property. 194 // property.
195 void PropertyHandlerCompiler::GenerateCheckPropertyCell( 195 void PropertyHandlerCompiler::GenerateCheckPropertyCell(
196 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name, 196 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name,
197 Register scratch, Label* miss) { 197 Register scratch, Label* miss) {
198 Handle<Cell> cell = JSGlobalObject::EnsurePropertyCell(global, name); 198 Handle<Cell> cell = JSGlobalObject::EnsurePropertyCell(global, name);
199 DCHECK(cell->value()->IsTheHole()); 199 DCHECK(cell->value()->IsTheHole());
200 __ li(scratch, Operand(cell)); 200 Handle<WeakCell> weak_cell = masm->isolate()->factory()->NewWeakCell(cell);
201 __ LoadWeakValue(scratch, weak_cell, miss);
201 __ lw(scratch, FieldMemOperand(scratch, Cell::kValueOffset)); 202 __ lw(scratch, FieldMemOperand(scratch, Cell::kValueOffset));
202 __ LoadRoot(at, Heap::kTheHoleValueRootIndex); 203 __ LoadRoot(at, Heap::kTheHoleValueRootIndex);
203 __ Branch(miss, ne, scratch, Operand(at)); 204 __ Branch(miss, ne, scratch, Operand(at));
204 } 205 }
205 206
206 207
207 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver, 208 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver,
208 Register holder, Register name, 209 Register holder, Register name,
209 Handle<JSObject> holder_obj) { 210 Handle<JSObject> holder_obj) {
210 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0); 211 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0);
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
742 // Return the generated code. 743 // Return the generated code.
743 return GetCode(kind(), Code::NORMAL, name); 744 return GetCode(kind(), Code::NORMAL, name);
744 } 745 }
745 746
746 747
747 #undef __ 748 #undef __
748 } 749 }
749 } // namespace v8::internal 750 } // namespace v8::internal
750 751
751 #endif // V8_TARGET_ARCH_MIPS 752 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698