Custom elements should have class side inheritance.

Custom elements should have class side inheritance.

We were not setting the __proto__ property of the generated constructor
so the generated class didn't inherit from the passed class which meant
that statics were not available.

This patch adds the missing call to setPrototype (which sets __proto__).

R=eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/88487174d62376e7a9365d3e1192673618b0ba6e

[eseidel, 2014-12-17 22:23:41]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2014-12-17 22:23:41]

lgtm

[esprehn, 2014-12-17 22:24:38]

Committed patchset #2 (id:20001) manually as
88487174d62376e7a9365d3e1192673618b0ba6e (presubmit successful).

[arv (Not doing code reviews), 2014-12-17 22:29:43]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2014-12-17 22:29:43]

https://codereview.chromium.org/814683002/diff/20001/sky/tests/custom-element...
File sky/tests/custom-elements/generated-constructor.sky (right):

https://codereview.chromium.org/814683002/diff/20001/sky/tests/custom-element...
sky/tests/custom-elements/generated-constructor.sky:7: class TestElementClass {
Don't you need extends HTMLElement as well?

https://codereview.chromium.org/814683002/diff/20001/sky/tests/custom-element...
sky/tests/custom-elements/generated-constructor.sky:14:
assert.equal(TestElement.test(), 10);
Maybe add:

assert.equal(Object.getPrototypeOf(TestElement), TestElementClass);

[esprehn, 2014-12-17 22:59:31]

On 2014/12/17 at 22:29:43, arv wrote:
>
https://codereview.chromium.org/814683002/diff/20001/sky/tests/custom-element...
> File sky/tests/custom-elements/generated-constructor.sky (right):
> 
>
https://codereview.chromium.org/814683002/diff/20001/sky/tests/custom-element...
> sky/tests/custom-elements/generated-constructor.sky:7: class TestElementClass
{
> Don't you need extends HTMLElement as well?
> 
>
https://codereview.chromium.org/814683002/diff/20001/sky/tests/custom-element...
> sky/tests/custom-elements/generated-constructor.sky:14:
assert.equal(TestElement.test(), 10);
> Maybe add:
> 
> assert.equal(Object.getPrototypeOf(TestElement), TestElementClass);

Fixed in https://codereview.chromium.org/809183002