sky/tests/custom-elements/generated-constructor.sky - Issue 814683002: Custom elements should have class side inheritance.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/tests/custom-elements/generated-constructor.sky

Issue 814683002: Custom elements should have class side inheritance. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: better test name. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>

	2 <import src="../resources/mocha.sky" />

	3 <import src="../resources/chai.sky" />

	4 <script>

	5 describe("Custom element constructor", function() {

	6 it("should inherit from the passed constructor", function() {

	7 class TestElementClass {
	arv (Not doing code reviews) 2014/12/17 22:29:43 Don't you need extends HTMLElement as well? Don't you need extends HTMLElement as well?
	8 static test() { return 10; }

	9 }

	10 var TestElement = document.registerElement("test-element-1", {

	11 prototype: TestElementClass.prototype,

	12 });

	13 assert.isFunction(TestElement.test);

	14 assert.equal(TestElement.test(), 10);
	arv (Not doing code reviews) 2014/12/17 22:29:43 Maybe add: assert.equal(Object.getPrototypeOf(Tes Maybe add: assert.equal(Object.getPrototypeOf(TestElement), TestElementClass);
	15 });

	16 });

	17 </script>

	18 </html>

OLD	NEW