Issue 809183002: Improve custom-elements/generated-constructor.sky test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 809183002: Improve custom-elements/generated-constructor.sky test. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
arv (Not doing code reviews), eseidel

CC:
mojo-reviews_chromium.org, ojan, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Improve custom-elements/generated-constructor.sky test. We should inherit from HTMLElement, Sky (and blink) don't currently enforce this but they probably should. We should also explicitly check that the prototype is what we expect. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a7e690f1c407acc5f6e4a76327f976ab19aa746a

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sky/tests/custom-elements/generated-constructor.sky	View		2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

esprehn

Committed patchset #1 (id:1) manually as a7e690f1c407acc5f6e4a76327f976ab19aa746a (presubmit successful).

6 years ago (2014-12-17 23:01:22 UTC) #1

Message was sent while issue was closed.

LGTM

Thanks