Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chrome/browser/profiles/profile_metrics.h

Issue 813133003: New Profile metric for Auth Errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android and Windows compiler errors Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_metrics.h
diff --git a/chrome/browser/profiles/profile_metrics.h b/chrome/browser/profiles/profile_metrics.h
index 1361dcdf1c3e8d66fce6a831dafe2fae0a259f4c..51dd5360135651d2f8765e5fb3d1ffee31cc772b 100644
--- a/chrome/browser/profiles/profile_metrics.h
+++ b/chrome/browser/profiles/profile_metrics.h
@@ -6,10 +6,12 @@
#define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
#include <stddef.h>
+
noms (inactive) 2014/12/19 19:33:01 nit: drop the empty line
Mike Lerman 2014/12/19 19:53:18 Done.
#include <string>
#include "base/basictypes.h"
#include "chrome/browser/signin/signin_header_helper.h"
+#include "google_apis/gaia/google_service_auth_error.h"
class Profile;
class ProfileManager;
@@ -26,9 +28,11 @@ class ProfileMetrics {
size_t supervised;
size_t unused;
size_t gaia_icon;
+ size_t auth_errors[GoogleServiceAuthError::State::NUM_STATES];
ProfileCounts()
- : total(0), signedin(0), supervised(0), unused(0), gaia_icon(0) {}
+ : total(0), signedin(0), supervised(0), unused(0), gaia_icon(0),
+ auth_errors() {}
noms (inactive) 2014/12/19 19:33:01 nit: now that they don't fit in one line, please a
Mike Lerman 2014/12/19 19:53:18 Like this?
noms (inactive) 2015/01/08 21:49:04 Yup!
Mike Lerman 2015/01/09 02:15:04 Acknowledged.
};
// Enum for counting the ways users were added.

Powered by Google App Engine
This is Rietveld 408576698