New Profile metric for Auth Errors.

chrome/browser/profiles/profile_metrics.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_
 
 #include <stddef.h>
+

[noms (inactive), 2014/12/19 19:33:01]

nit: drop the empty line

[Mike Lerman, 2014/12/19 19:53:18]

Done.

 #include <string>
 
 #include "base/basictypes.h"
 #include "chrome/browser/signin/signin_header_helper.h"
+#include "google_apis/gaia/google_service_auth_error.h"
 
 class Profile;
 class ProfileManager;
 
 namespace base {
 class FilePath;
 }
 
 class ProfileMetrics {
  public:
   struct ProfileCounts {
     size_t total;
     size_t signedin;
     size_t supervised;
     size_t unused;
     size_t gaia_icon;
+    size_t auth_errors[GoogleServiceAuthError::State::NUM_STATES];
 
     ProfileCounts()
-        : total(0), signedin(0), supervised(0), unused(0), gaia_icon(0) {}
+        : total(0), signedin(0), supervised(0), unused(0), gaia_icon(0),
+          auth_errors() {}

[noms (inactive), 2014/12/19 19:33:01]

nit: now that they don't fit in one line, please align all the initializers.

[Mike Lerman, 2014/12/19 19:53:18]

Like this?

[noms (inactive), 2015/01/08 21:49:04]

Yup!

[Mike Lerman, 2015/01/09 02:15:04]

Acknowledged.

   };
 
   // Enum for counting the ways users were added.
   enum ProfileAdd {
     ADD_NEW_USER_ICON = 0,      // User adds new user from icon menu
     ADD_NEW_USER_MENU,          // User adds new user from menu bar
     ADD_NEW_USER_DIALOG,        // User adds new user from create-profile dialog
     ADD_NEW_USER_MANAGER,       // User adds new user from User Manager
     ADD_NEW_USER_LAST_DELETED,  // Auto-created after deleting last user
     NUM_PROFILE_ADD_METRICS
@@ skipping 184 matching lines @@
 
   // These functions should only be called on the UI thread because they hook
   // into g_browser_process through a helper function.
   static void LogProfileLaunch(Profile* profile);
   static void LogProfileSyncSignIn(const base::FilePath& profile_path);
   static void LogProfileUpdate(const base::FilePath& profile_path);
 };
 
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_METRICS_H_