New Profile metric for Auth Errors.

chrome/test/base/testing_profile_manager.h

Index: chrome/test/base/testing_profile_manager.h
diff --git a/chrome/test/base/testing_profile_manager.h b/chrome/test/base/testing_profile_manager.h
index 8fcd7a29323c63952f85b295f9a31435acfbb4b7..52f357f22e3891019a625437a96d4172c4f7f167 100644
--- a/chrome/test/base/testing_profile_manager.h
+++ b/chrome/test/base/testing_profile_manager.h
@@ -84,6 +84,9 @@ class TestingProfileManager {
   // Sets ProfileManager's logged_in state. This is only useful on ChromeOS.
   void SetLoggedIn(bool logged_in);
 
+  // Sets the last used profile; also sets the active time to now.
+  void UpdateLastUser(Profile* last_active);

[noms (inactive), 2014/12/19 19:33:01]

Bleh, this name doesn't really agree with the comment. How about something like
SetLastUsedProfile()?
(i know it's calling UpdateLastUser on the profile manager, but I don't think
that method is well named either)

[Mike Lerman, 2014/12/19 19:53:18]

I really think they should have the same name, since they're doing the same
thing and this is just exposing the ProfileManager's private call. Giving them
different names would be confusing.

If I'll rename them, then I'll rename both. I don't like SetLastUsedProfile
since the method does more than just set the LastUsedProfile in the LocalState,
it also updates the active time of the ProfileInfo Cache. How about
MarkProfileActive()?

You're just getting me back for the signin_metrics thing aren't you ;)

+
   // Helper accessors.
   const base::FilePath& profiles_dir();
   ProfileManager* profile_manager();