Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 812133003: Added unit tests for max_frame_delay and frame_lengths (Closed)

Created:
6 years ago by sullivan
Modified:
6 years ago
Reviewers:
nednguyen, ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added unit tests for max_frame_delay and frame_lengths BUG= Committed: https://crrev.com/ddea131f968cfc12e0686118edeab75903295855 Cr-Commit-Position: refs/heads/master@{#309572}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/perf/measurements/smoothness_unittest.py View 1 chunk +8 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (4 generated)
sullivan
This is a follow-up to https://codereview.chromium.org/814813003/, updates to test all the SurfaceFlinger metrics.
6 years ago (2014-12-23 15:24:10 UTC) #2
nednguyen
https://codereview.chromium.org/812133003/diff/1/tools/perf/measurements/smoothness_unittest.py File tools/perf/measurements/smoothness_unittest.py (right): https://codereview.chromium.org/812133003/diff/1/tools/perf/measurements/smoothness_unittest.py#newcode145 tools/perf/measurements/smoothness_unittest.py:145: Wouldn't these only work for android?
6 years ago (2014-12-23 15:39:11 UTC) #3
sullivan
https://codereview.chromium.org/812133003/diff/1/tools/perf/measurements/smoothness_unittest.py File tools/perf/measurements/smoothness_unittest.py (right): https://codereview.chromium.org/812133003/diff/1/tools/perf/measurements/smoothness_unittest.py#newcode145 tools/perf/measurements/smoothness_unittest.py:145: On 2014/12/23 15:39:11, nednguyen wrote: > Wouldn't these only ...
6 years ago (2014-12-23 15:42:59 UTC) #4
nednguyen
On 2014/12/23 15:42:59, sullivan wrote: > https://codereview.chromium.org/812133003/diff/1/tools/perf/measurements/smoothness_unittest.py > File tools/perf/measurements/smoothness_unittest.py (right): > > https://codereview.chromium.org/812133003/diff/1/tools/perf/measurements/smoothness_unittest.py#newcode145 > ...
6 years ago (2014-12-23 16:29:18 UTC) #5
ernstm
lgtm
6 years ago (2014-12-23 17:41:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812133003/1
6 years ago (2014-12-23 17:42:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/17541)
6 years ago (2014-12-23 18:20:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812133003/1
6 years ago (2014-12-23 18:50:20 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 19:26:12 UTC) #13
commit-bot: I haz the power
6 years ago (2014-12-23 19:27:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddea131f968cfc12e0686118edeab75903295855
Cr-Commit-Position: refs/heads/master@{#309572}

Powered by Google App Engine
This is Rietveld 408576698