Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: tools/perf/measurements/smoothness_unittest.py

Issue 812133003: Added unit tests for max_frame_delay and frame_lengths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/smoothness_unittest.py
diff --git a/tools/perf/measurements/smoothness_unittest.py b/tools/perf/measurements/smoothness_unittest.py
index fc8a87509b66a7c33718050805a4957d1328584b..9723bb18aa16d70fe0cb2602c24997921d3da1a3 100644
--- a/tools/perf/measurements/smoothness_unittest.py
+++ b/tools/perf/measurements/smoothness_unittest.py
@@ -143,6 +143,14 @@ class SmoothnessUnitTest(page_test_test_case.PageTestTestCase):
self.assertEquals(1, len(jank_count))
self.assertGreater(jank_count[0].GetRepresentativeNumber(), -1)
nednguyen 2014/12/23 15:39:11 Wouldn't these only work for android?
sullivan 2014/12/23 15:42:59 Yep, they only work for Android. The code review t
+ max_frame_delay = results.FindAllPageSpecificValuesNamed('max_frame_delay')
+ self.assertEquals(1, len(max_frame_delay))
+ self.assertGreater(max_frame_delay[0].GetRepresentativeNumber, 0)
+
+ frame_lengths = results.FindAllPageSpecificValuesNamed('frame_lengths')
+ self.assertEquals(1, len(frame_lengths))
+ self.assertGreater(frame_lengths[0].GetRepresentativeNumber, 0)
+
@decorators.Disabled('mac', 'chromeos') # http://crbug.com/403903
def testSmoothnessForPageWithNoGesture(self):
ps = self.CreateEmptyPageSet()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698