Added unit tests for max_frame_delay and frame_lengths

tools/perf/measurements/smoothness_unittest.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import sys
 
 from measurements import smoothness
 from metrics import power
 from telemetry import decorators
 from telemetry.core import exceptions
 from telemetry.core import wpr_modes
@@ skipping 124 matching lines @@
     results = self.RunMeasurement(measurement, ps, options=self._options)
     self.assertEquals(0, len(results.failures))
 
     avg_surface_fps = results.FindAllPageSpecificValuesNamed('avg_surface_fps')
     self.assertEquals(1, len(avg_surface_fps))
     self.assertGreater(avg_surface_fps[0].GetRepresentativeNumber, 0)
 
     jank_count = results.FindAllPageSpecificValuesNamed('jank_count')
     self.assertEquals(1, len(jank_count))
     self.assertGreater(jank_count[0].GetRepresentativeNumber(), -1)
 

[nednguyen, 2014/12/23 15:39:11]

Wouldn't these only work for android?

[sullivan, 2014/12/23 15:42:59]

Yep, they only work for Android. The code review tool helpfully hides the top of
this test:

@decorators.Enabled('android')  # SurfaceFlinger is android-only
  def testSmoothnessSurfaceFlingerMetricsCalculated(self):

+    max_frame_delay = results.FindAllPageSpecificValuesNamed('max_frame_delay')
+    self.assertEquals(1, len(max_frame_delay))
+    self.assertGreater(max_frame_delay[0].GetRepresentativeNumber, 0)
+
+    frame_lengths = results.FindAllPageSpecificValuesNamed('frame_lengths')
+    self.assertEquals(1, len(frame_lengths))
+    self.assertGreater(frame_lengths[0].GetRepresentativeNumber, 0)
+
   @decorators.Disabled('mac', 'chromeos')  # http://crbug.com/403903
   def testSmoothnessForPageWithNoGesture(self):
     ps = self.CreateEmptyPageSet()
     ps.AddUserStory(AnimatedPage(ps))
 
     measurement = smoothness.Smoothness()
     results = self.RunMeasurement(measurement, ps, options=self._options)
     self.assertEquals(0, len(results.failures))
 
     percentage_smooth = results.FindAllPageSpecificValuesNamed(
@@ skipping 32 matching lines @@
         self.fake_power = self._power_metric = FakePowerMetric(platform)
 
     measurement = BuggyMeasurement()
     try:
       self.RunMeasurement(measurement, ps)
     except exceptions.IntentionalException:
       pass
 
     self.assertTrue(measurement.fake_power.start_called)
     self.assertTrue(measurement.fake_power.stop_called)