Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 812063002: Change to create device coord coordset (Closed)

Created:
6 years ago by joshua.litt
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@vm-off-context
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change to create device coord coordset BUG=skia: Committed: https://skia.googlesource.com/skia/+/16b278989532ee9f9a38e3eb4754b228ff495cb8

Patch Set 1 #

Total comments: 3

Patch Set 2 : bug fix #

Patch Set 3 : cleanup #

Patch Set 4 : cleanup #

Patch Set 5 : cleanup #

Patch Set 6 : more cleanup #

Patch Set 7 : nit #

Patch Set 8 : ignoring bleed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -63 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 3 4 5 6 1 chunk +22 lines, -12 lines 0 comments Download
M include/gpu/GrCoordTransform.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 5 2 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 6 4 chunks +20 lines, -18 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 chunk +29 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
This change is currently currently only 'works' if I leave the inversion in place on ...
6 years ago (2014-12-17 18:47:40 UTC) #2
bsalomon
https://codereview.chromium.org/812063002/diff/1/src/gpu/GrPendingFragmentStage.h File src/gpu/GrPendingFragmentStage.h (right): https://codereview.chromium.org/812063002/diff/1/src/gpu/GrPendingFragmentStage.h#newcode52 src/gpu/GrPendingFragmentStage.h:52: kDevice_GrCoordSet == coordTransform.sourceCoords()) { This is backwards... don't want ...
6 years ago (2014-12-17 19:45:28 UTC) #3
joshualitt
CL is updated
6 years ago (2014-12-17 20:09:56 UTC) #4
bsalomon
lgtm
6 years ago (2014-12-17 21:11:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812063002/140001
6 years ago (2014-12-18 15:38:38 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-18 15:47:21 UTC) #8
Message was sent while issue was closed. 
Committed patchset #8 (id:140001) as
https://skia.googlesource.com/skia/+/16b278989532ee9f9a38e3eb4754b228ff495cb8

Powered by Google App Engine
This is Rietveld 408576698