Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 809653004: [Telemetry] Remove session_restore.{cold|warm}.startup_urls (previously disabled) (Closed)

Created:
6 years ago by slamm
Modified:
6 years ago
Reviewers:
sullivan, tonyg, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org, chrishenry
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove disabled tests session_restore.cold.startup_urls and session_restore.warm.startup_urls. These are adding to the maintenance burden. If they need to be brought back to life, the measurement will need a substitute for CanRunForPage because that method is going away. https://codereview.chromium.org/808893002/ The CL that disabled the tests: https://codereview.chromium.org/738663002 BUG=389142, 405386, 440101 Committed: https://crrev.com/ce9f11ad6c803515f5bc170629a2f795bd275d43 Cr-Commit-Position: refs/heads/master@{#308737}

Patch Set 1 : [Telemetry] Remove disabled tests session_restore.cold.startup_urls and session_restore.warm.startu… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M tools/perf/benchmarks/session_restore.py View 2 chunks +0 lines, -21 lines 0 comments Download
D tools/perf/measurements/session_restore_with_url.py View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
slamm
Annie, these are the tests I asked about removing earlier today.
6 years ago (2014-12-17 00:32:21 UTC) #3
slamm
On 2014/12/17 00:32:21, slamm wrote: > Annie, these are the tests I asked about removing ...
6 years ago (2014-12-17 00:38:00 UTC) #5
chrishenry
lgtm, thanks!
6 years ago (2014-12-17 00:42:32 UTC) #7
sullivan
lgtm
6 years ago (2014-12-17 00:49:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/809653004/20001
6 years ago (2014-12-17 01:07:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years ago (2014-12-17 03:06:29 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-17 03:07:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce9f11ad6c803515f5bc170629a2f795bd275d43
Cr-Commit-Position: refs/heads/master@{#308737}

Powered by Google App Engine
This is Rietveld 408576698