Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 738663002: [Telemetry] Disable session restore with URL benchmarks. (Closed)

Created:
6 years, 1 month ago by tonyg
Modified:
6 years, 1 month ago
Reviewers:
sullivan, jeremy
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Disable session restore with URL benchmarks. Session restore + URL doesn't seem to make a lot of sense and the codepath is horribly broken. This'll need better unittesting if anyone plans to bring it back. BUG=405386 Committed: https://crrev.com/7026d9be1f788447690cb4ed2db2a321a8407775 Cr-Commit-Position: refs/heads/master@{#304607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/perf/benchmarks/session_restore.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tonyg
6 years, 1 month ago (2014-11-18 04:50:32 UTC) #2
jeremy
LGTM
6 years, 1 month ago (2014-11-18 06:36:10 UTC) #3
sullivan
lgtm
6 years, 1 month ago (2014-11-18 14:38:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/738663002/1
6 years, 1 month ago (2014-11-18 14:38:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 15:34:31 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 15:35:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7026d9be1f788447690cb4ed2db2a321a8407775
Cr-Commit-Position: refs/heads/master@{#304607}

Powered by Google App Engine
This is Rietveld 408576698