tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/value/summary.py ('K') | « tools/telemetry/telemetry/web_perf/metrics/layout.py ('k') | tools/telemetry/telemetry/web_perf/metrics/smoothness.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py b/tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py

index 1864fc77b34aba72adebc2ea94a9e78b0ee0c3d6..95f6cbe3103c8b0e1dacf567b40d1af8795ec30a 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py

@@ -3,6 +3,7 @@

# found in the LICENSE file.

import logging

+from telemetry.value import improvement_direction

from telemetry.value import scalar

from telemetry.web_perf import timeline_interaction_record as tir_module

from telemetry.web_perf.metrics import mainthread_jank_stats

@@ -44,7 +45,9 @@ class ResponsivenessMetric(timeline_based_metric.TimelineBasedMetric):

results.AddValue(scalar.ScalarValue(

results.current_page, 'responsive-total_big_jank_thread_time', 'ms',

- jank_stats.total_big_jank_thread_time))

+ jank_stats.total_big_jank_thread_time,

+ improvement_direction=improvement_direction.DOWN))

results.AddValue(scalar.ScalarValue(

results.current_page, 'responsive-biggest_jank_thread_time', 'ms',

- jank_stats.biggest_jank_thread_time))

+ jank_stats.biggest_jank_thread_time,

+ improvement_direction=improvement_direction.DOWN))