tools/telemetry/telemetry/web_perf/metrics/layout.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/layout.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/value/summary.py ('K') | « tools/telemetry/telemetry/web_perf/metrics/fast_metric.py ('k') | tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/metrics/layout.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/layout.py b/tools/telemetry/telemetry/web_perf/metrics/layout.py

index baa5295a7aa2a35b73531b03dd292c87b8b76074..fe2bd990285dfbead99fe96b76ff750237b37766 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/layout.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/layout.py

@@ -3,6 +3,7 @@

# found in the LICENSE file.

import math

+from telemetry.value import improvement_direction

from telemetry.value import scalar

from telemetry.web_perf.metrics import timeline_based_metric

@@ -51,7 +52,9 @@ class LayoutMetric(timeline_based_metric.TimelineBasedMetric):

stddev = math.sqrt(sum((d - avg) ** 2 for d in durations) / count)

results.AddValue(scalar.ScalarValue(results.current_page,

short_name + '_avg', 'ms', avg,

- description='Average duration of %s events' % long_name))

+ description='Average duration of %s events' % long_name,

+ improvement_direction=improvement_direction.DOWN))

results.AddValue(scalar.ScalarValue(results.current_page,

short_name + '_stddev', 'ms', stddev,

- description='stddev of duration of %s events' % long_name))

+ description='stddev of duration of %s events' % long_name,

+ improvement_direction=improvement_direction.DOWN))