Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Unified Diff: tools/telemetry/telemetry/value/summary.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/summary.py
diff --git a/tools/telemetry/telemetry/value/summary.py b/tools/telemetry/telemetry/value/summary.py
index 13e8ac20dfc52ba5b387fa9940d4d82099cbc6f5..59e9ad24d07bf376ccc9b6efd82c55f81a01bb1d 100644
--- a/tools/telemetry/telemetry/value/summary.py
+++ b/tools/telemetry/telemetry/value/summary.py
@@ -7,6 +7,7 @@ from collections import defaultdict
from telemetry.value import failure
from telemetry.value import merge_values
from telemetry.value import skip
+from telemetry.value import summarizable
class Summary(object):
@@ -67,6 +68,10 @@ class Summary(object):
v for v in all_page_specific_values if not (isinstance(
v, failure.FailureValue) or isinstance(v, skip.SkipValue))]
+ # All successful values must be summarizable.
+ for v in all_successful_page_values:
+ assert isinstance(v, summarizable.SummarizableValue), "Not summarizable: %r" % v
qyearsley 2015/01/27 00:50:46 Looks like it's just over 80 chars. Also, I think
+
# We will later need to determine how many values were originally created
# for each value name, to apply a workaround meant to clean up the printf
# output.

Powered by Google App Engine
This is Rietveld 408576698