tools/telemetry/telemetry/user_story/user_story_runner_unittest.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/user_story/user_story_runner_unittest.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results_unittest.py ('k') | tools/telemetry/telemetry/value/histogram.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/user_story/user_story_runner_unittest.py

diff --git a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py

index 82ef558eebe4e4b173b08389d9e2c8f02360abe5..815289bc792a01e2aa7890b6d28afa6d76e79199 100644

--- a/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py

+++ b/tools/telemetry/telemetry/user_story/user_story_runner_unittest.py

@@ -20,6 +20,7 @@ from telemetry.user_story import user_story_runner

from telemetry.user_story import user_story_set

from telemetry.util import cloud_storage

from telemetry.util import exception_formatter as exception_formatter_module

+from telemetry.value import improvement_direction

from telemetry.value import scalar

from telemetry.value import string

from telemetry.web_perf import timeline_based_measurement

@@ -407,7 +408,8 @@ class UserStoryRunnerTest(unittest.TestCase):

def RunPage(self, page, _, results):

self.i += 1

results.AddValue(scalar.ScalarValue(

- page, 'metric', 'unit', self.i))

+ page, 'metric', 'unit', self.i,

+ improvement_direction=improvement_direction.UP))

def ValidateAndMeasurePage(self, page, tab, results):

pass