tools/telemetry/telemetry/results/html_output_formatter_unittest.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Unified Diff: tools/telemetry/telemetry/results/html_output_formatter_unittest.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/csv_pivot_table_output_formatter_unittest.py ('k') | tools/telemetry/telemetry/results/json_output_formatter_unittest.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/html_output_formatter_unittest.py

diff --git a/tools/telemetry/telemetry/results/html_output_formatter_unittest.py b/tools/telemetry/telemetry/results/html_output_formatter_unittest.py

index 3c69cfef91b966aaccd615938a254276455e4f0a..29b3fbffb735678620bee5d5589e23c0ac4218bb 100644

--- a/tools/telemetry/telemetry/results/html_output_formatter_unittest.py

+++ b/tools/telemetry/telemetry/results/html_output_formatter_unittest.py

@@ -10,6 +10,7 @@ from telemetry import page as page_module

from telemetry.page import page_set

from telemetry.results import html_output_formatter

from telemetry.results import page_test_results

+from telemetry.value import improvement_direction

from telemetry.value import scalar

@@ -48,12 +49,14 @@ class HtmlOutputFormatterTest(unittest.TestCase):

results = page_test_results.PageTestResults()

results.WillRunPage(test_page_set.pages[0])

results.AddValue(scalar.ScalarValue(

- test_page_set.pages[0], 'a', 'seconds', 3))

+ test_page_set.pages[0], 'a', 'seconds', 3,

+ improvement_direction=improvement_direction.DOWN))

results.DidRunPage(test_page_set.pages[0])

results.WillRunPage(test_page_set.pages[1])

results.AddValue(scalar.ScalarValue(

- test_page_set.pages[1], 'a', 'seconds', 7))

+ test_page_set.pages[1], 'a', 'seconds', 7,

+ improvement_direction=improvement_direction.DOWN))

results.DidRunPage(test_page_set.pages[1])

formatter = DeterministicHtmlOutputFormatter(

@@ -103,12 +106,14 @@ class HtmlOutputFormatterTest(unittest.TestCase):

results = page_test_results.PageTestResults()

results.WillRunPage(test_page_set.pages[0])

results.AddValue(scalar.ScalarValue(

- test_page_set.pages[0], 'a', 'seconds', 4))

+ test_page_set.pages[0], 'a', 'seconds', 4,

+ improvement_direction=improvement_direction.DOWN))

results.DidRunPage(test_page_set.pages[0])

results.WillRunPage(test_page_set.pages[1])

results.AddValue(scalar.ScalarValue(

- test_page_set.pages[1], 'a', 'seconds', 8))

+ test_page_set.pages[1], 'a', 'seconds', 8,

+ improvement_direction=improvement_direction.DOWN))

results.DidRunPage(test_page_set.pages[1])

formatter = DeterministicHtmlOutputFormatter(

@@ -197,12 +202,14 @@ class HtmlOutputFormatterTest(unittest.TestCase):

results = page_test_results.PageTestResults()

results.WillRunPage(test_page_set.pages[0])

results.AddValue(scalar.ScalarValue(

- test_page_set.pages[0], 'a', 'seconds', 5))

+ test_page_set.pages[0], 'a', 'seconds', 5,

+ improvement_direction=improvement_direction.DOWN))

results.DidRunPage(test_page_set.pages[0])

results.WillRunPage(test_page_set.pages[1])

results.AddValue(scalar.ScalarValue(

- test_page_set.pages[1], 'a', 'seconds', 9))

+ test_page_set.pages[1], 'a', 'seconds', 9,

+ improvement_direction=improvement_direction.DOWN))

results.DidRunPage(test_page_set.pages[1])

formatter = DeterministicHtmlOutputFormatter(