Added support for improvement_direction to relevant values, which is propogated to chartjson.

tools/telemetry/telemetry/results/html_output_formatter_unittest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import os
 import StringIO
 import unittest
 
 from telemetry import benchmark
 from telemetry import page as page_module
 from telemetry.page import page_set
 from telemetry.results import html_output_formatter
 from telemetry.results import page_test_results
+from telemetry.value import improvement_direction
 from telemetry.value import scalar
 
 
 def _MakePageSet():
   ps = page_set.PageSet(file_path=os.path.dirname(__file__))
   ps.AddUserStory(page_module.Page('http://www.foo.com/', ps, ps.base_dir))
   ps.AddUserStory(page_module.Page('http://www.bar.com/', ps, ps.base_dir))
   ps.AddUserStory(page_module.Page('http://www.baz.com/', ps, ps.base_dir))
   return ps
 
@@ skipping 18 matching lines @@
 class HtmlOutputFormatterTest(unittest.TestCase):
 
   def test_basic_summary(self):
     test_page_set = _MakePageSet()
     output_file = StringIOFile()
 
     # Run the first time and verify the results are written to the HTML file.
     results = page_test_results.PageTestResults()
     results.WillRunPage(test_page_set.pages[0])
     results.AddValue(scalar.ScalarValue(
-        test_page_set.pages[0], 'a', 'seconds', 3))
+        test_page_set.pages[0], 'a', 'seconds', 3,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(test_page_set.pages[0])
 
     results.WillRunPage(test_page_set.pages[1])
     results.AddValue(scalar.ScalarValue(
-        test_page_set.pages[1], 'a', 'seconds', 7))
+        test_page_set.pages[1], 'a', 'seconds', 7,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(test_page_set.pages[1])
 
     formatter = DeterministicHtmlOutputFormatter(
         output_file, FakeMetadataForTest(), False, False, 'browser_type')
     formatter.Format(results)
     expected = {
       "platform": "browser_type",
       "buildTime": "build_time",
       "label": None,
       "tests": {
@@ skipping 29 matching lines @@
       },
       "revision": "revision"
     }
     self.assertEquals(expected, formatter.GetResults())
 
     # Run the second time and verify the results are appended to the HTML file.
     output_file.seek(0)
     results = page_test_results.PageTestResults()
     results.WillRunPage(test_page_set.pages[0])
     results.AddValue(scalar.ScalarValue(
-        test_page_set.pages[0], 'a', 'seconds', 4))
+        test_page_set.pages[0], 'a', 'seconds', 4,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(test_page_set.pages[0])
 
     results.WillRunPage(test_page_set.pages[1])
     results.AddValue(scalar.ScalarValue(
-        test_page_set.pages[1], 'a', 'seconds', 8))
+        test_page_set.pages[1], 'a', 'seconds', 8,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(test_page_set.pages[1])
 
     formatter = DeterministicHtmlOutputFormatter(
         output_file, FakeMetadataForTest(), False, False, 'browser_type')
     formatter.Format(results)
     expected = [
       {
         "platform": "browser_type",
         "buildTime": "build_time",
         "label": None,
@@ skipping 68 matching lines @@
         "revision": "revision"
       }]
     self.assertEquals(expected, formatter.GetCombinedResults())
     last_output_len = len(output_file.getvalue())
 
     # Now reset the results and verify the old ones are gone.
     output_file.seek(0)
     results = page_test_results.PageTestResults()
     results.WillRunPage(test_page_set.pages[0])
     results.AddValue(scalar.ScalarValue(
-        test_page_set.pages[0], 'a', 'seconds', 5))
+        test_page_set.pages[0], 'a', 'seconds', 5,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(test_page_set.pages[0])
 
     results.WillRunPage(test_page_set.pages[1])
     results.AddValue(scalar.ScalarValue(
-        test_page_set.pages[1], 'a', 'seconds', 9))
+        test_page_set.pages[1], 'a', 'seconds', 9,
+        improvement_direction=improvement_direction.DOWN))
     results.DidRunPage(test_page_set.pages[1])
 
     formatter = DeterministicHtmlOutputFormatter(
        output_file, FakeMetadataForTest(), True, False, 'browser_type')
     formatter.Format(results)
     expected = [{
       "platform": "browser_type",
       "buildTime": "build_time",
       "label": None,
       "tests": {
@@ skipping 24 matching lines @@
               "units": "seconds",
               "important": False
             }
           }
         }
       },
       "revision": "revision"
     }]
     self.assertEquals(expected, formatter.GetCombinedResults())
     self.assertTrue(len(output_file.getvalue()) < last_output_len)