tools/perf/measurements/tab_switching.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/tab_switching.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix linter issues Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/measurements/skpicture_printer.py ('k') | tools/perf/measurements/task_execution_time.py » ('j') | tools/telemetry/telemetry/value/scalar.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/measurements/tab_switching.py

diff --git a/tools/perf/measurements/tab_switching.py b/tools/perf/measurements/tab_switching.py

index 41290dc07de244e293b794f3c951467bfae2d0d0..82bec69fb3b32a5be6232fdf63ac1c86c82f433c 100644

--- a/tools/perf/measurements/tab_switching.py

+++ b/tools/perf/measurements/tab_switching.py

@@ -17,6 +17,7 @@ from telemetry.core import util

from telemetry.page import page_test

from telemetry.value import histogram

from telemetry.value import histogram_util

+from telemetry.value import improvement_direction

# TODO: Revisit this test once multitab support is finalized.

@@ -96,6 +97,6 @@ class TabSwitching(page_test.PageTest):

first_histogram)

results.AddSummaryValue(

- histogram.HistogramValue(None, display_name, 'ms',

- raw_value_json=diff_histogram,

- important=False))

+ histogram.HistogramValue(

+ None, display_name, 'ms', raw_value_json=diff_histogram,

+ important=False, improvement_direction=improvement_direction.DOWN))