Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: tools/perf/measurements/skpicture_printer.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/skpicture_printer.py
diff --git a/tools/perf/measurements/skpicture_printer.py b/tools/perf/measurements/skpicture_printer.py
index fd41e67ddc6844248327875f66078f1ddbe296da..f9c109dce02b695016d28f49941f04b0932fb924 100644
--- a/tools/perf/measurements/skpicture_printer.py
+++ b/tools/perf/measurements/skpicture_printer.py
@@ -5,6 +5,7 @@ import glob
import os
from telemetry.page import page_test
+from telemetry.value import improvement_direction
from telemetry.value import scalar
@@ -33,4 +34,5 @@ class SkpicturePrinter(page_test.PageTest):
tab.EvaluateJavaScript(js)
pictures = glob.glob(os.path.join(outpath, '*.skp'))
results.AddValue(scalar.ScalarValue(
- results.current_page, 'saved_picture_count', 'count', len(pictures)))
+ results.current_page, 'saved_picture_count', 'count', len(pictures),
+ improvement_direction=improvement_direction.DOWN))

Powered by Google App Engine
This is Rietveld 408576698