Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: tools/perf/measurements/tab_switching.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """The tab switching measurement. 5 """The tab switching measurement.
6 6
7 This measurement opens pages in different tabs. After all the tabs have opened, 7 This measurement opens pages in different tabs. After all the tabs have opened,
8 it cycles through each tab in sequence, and records a histogram of the time 8 it cycles through each tab in sequence, and records a histogram of the time
9 between when a tab was first requested to be shown, and when it was painted. 9 between when a tab was first requested to be shown, and when it was painted.
10 Power usage is also measured. 10 Power usage is also measured.
11 """ 11 """
12 12
13 import time 13 import time
14 14
15 from metrics import power 15 from metrics import power
16 from telemetry.core import util 16 from telemetry.core import util
17 from telemetry.page import page_test 17 from telemetry.page import page_test
18 from telemetry.value import histogram 18 from telemetry.value import histogram
19 from telemetry.value import histogram_util 19 from telemetry.value import histogram_util
20 from telemetry.value import improvement_direction
20 21
21 # TODO: Revisit this test once multitab support is finalized. 22 # TODO: Revisit this test once multitab support is finalized.
22 23
23 class TabSwitching(page_test.PageTest): 24 class TabSwitching(page_test.PageTest):
24 25
25 # Amount of time to measure, in seconds. 26 # Amount of time to measure, in seconds.
26 SAMPLE_TIME = 30 27 SAMPLE_TIME = 30
27 28
28 def __init__(self): 29 def __init__(self):
29 super(TabSwitching, self).__init__() 30 super(TabSwitching, self).__init__()
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 util.WaitFor(_IsDone, 30) 90 util.WaitFor(_IsDone, 30)
90 prev_histogram = histogram_util.GetHistogram( 91 prev_histogram = histogram_util.GetHistogram(
91 histogram_type, histogram_name, tab) 92 histogram_type, histogram_name, tab)
92 93
93 last_histogram = histogram_util.GetHistogram( 94 last_histogram = histogram_util.GetHistogram(
94 histogram_type, histogram_name, tab) 95 histogram_type, histogram_name, tab)
95 diff_histogram = histogram_util.SubtractHistogram(last_histogram, 96 diff_histogram = histogram_util.SubtractHistogram(last_histogram,
96 first_histogram) 97 first_histogram)
97 98
98 results.AddSummaryValue( 99 results.AddSummaryValue(
99 histogram.HistogramValue(None, display_name, 'ms', 100 histogram.HistogramValue(
100 raw_value_json=diff_histogram, 101 None, display_name, 'ms', raw_value_json=diff_histogram,
101 important=False)) 102 important=False, improvement_direction=improvement_direction.DOWN))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698