Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1790)

Unified Diff: tools/perf/measurements/tab_switching.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/tab_switching.py
diff --git a/tools/perf/measurements/tab_switching.py b/tools/perf/measurements/tab_switching.py
index 41290dc07de244e293b794f3c951467bfae2d0d0..82bec69fb3b32a5be6232fdf63ac1c86c82f433c 100644
--- a/tools/perf/measurements/tab_switching.py
+++ b/tools/perf/measurements/tab_switching.py
@@ -17,6 +17,7 @@ from telemetry.core import util
from telemetry.page import page_test
from telemetry.value import histogram
from telemetry.value import histogram_util
+from telemetry.value import improvement_direction
# TODO: Revisit this test once multitab support is finalized.
@@ -96,6 +97,6 @@ class TabSwitching(page_test.PageTest):
first_histogram)
results.AddSummaryValue(
- histogram.HistogramValue(None, display_name, 'ms',
- raw_value_json=diff_histogram,
- important=False))
+ histogram.HistogramValue(
+ None, display_name, 'ms', raw_value_json=diff_histogram,
+ important=False, improvement_direction=improvement_direction.DOWN))

Powered by Google App Engine
This is Rietveld 408576698