Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1711)

Unified Diff: tools/perf/measurements/screenshot.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/measurements/screenshot.py
diff --git a/tools/perf/measurements/screenshot.py b/tools/perf/measurements/screenshot.py
index 37936f8a90a80482afc629d3eb589ea3d61ac48f..7b514450a174ebbd04f8201c4f2b2301fa571460 100644
--- a/tools/perf/measurements/screenshot.py
+++ b/tools/perf/measurements/screenshot.py
@@ -6,6 +6,7 @@ import os
from telemetry.image_processing import image_util
from telemetry.page import page_test
from telemetry.page import page_test
+from telemetry.value import improvement_direction
from telemetry.value import scalar
@@ -39,4 +40,5 @@ class Screenshot(page_test.PageTest):
saved_picture_count = 1
results.AddValue(scalar.ScalarValue(
results.current_page, 'saved_picture_count', 'count',
- saved_picture_count))
+ saved_picture_count,
+ improvement_direction=improvement_direction.DOWN))

Powered by Google App Engine
This is Rietveld 408576698