Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tools/perf/benchmarks/octane.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/octane.py
diff --git a/tools/perf/benchmarks/octane.py b/tools/perf/benchmarks/octane.py
index 4fdecaea8475beec35781b9db3d911ee22001a52..a7863f98fe67adbf179225b0e1b6278dea7e1911 100644
--- a/tools/perf/benchmarks/octane.py
+++ b/tools/perf/benchmarks/octane.py
@@ -19,6 +19,7 @@ from telemetry import page as page_module
from telemetry.page import page_set
from telemetry.page import page_test
from telemetry.util import statistics
+from telemetry.value import improvement_direction
from telemetry.value import scalar
_GB = 1024 * 1024 * 1024
@@ -118,7 +119,8 @@ class _OctaneMeasurement(page_test.PageTest):
score = int(score_and_name[1])
results.AddValue(scalar.ScalarValue(
results.current_page, name, 'score', score, important=False,
- description=DESCRIPTIONS.get(name)))
+ description=DESCRIPTIONS.get(name),
+ improvement_direction=improvement_direction.UP))
# Collect all test scores to compute geometric mean.
all_scores.append(score)
@@ -127,7 +129,8 @@ class _OctaneMeasurement(page_test.PageTest):
scalar.ScalarValue(None, 'Total.Score', 'score', total,
description='Geometric mean of the scores of each '
'individual benchmark in the Octane '
- 'benchmark collection.'))
+ 'benchmark collection.',
+ improvement_direction=improvement_direction.UP))
class Octane(benchmark.Benchmark):

Powered by Google App Engine
This is Rietveld 408576698