Added support for improvement_direction to relevant values, which is propogated to chartjson.

tools/perf/benchmarks/octane.py

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Octane 2.0 javascript benchmark.
 
 Octane 2.0 is a modern benchmark that measures a JavaScript engine's performance
 by running a suite of tests representative of today's complex and demanding web
 applications. Octane's goal is to measure the performance of JavaScript code
 found in large, real-world web applications.
 Octane 2.0 consists of 17 tests, four more than Octane v1.
 """
 
 import os
 
 from metrics import power
 from telemetry import benchmark
 from telemetry import page as page_module
 from telemetry.page import page_set
 from telemetry.page import page_test
 from telemetry.util import statistics
+from telemetry.value import improvement_direction
 from telemetry.value import scalar
 
 _GB = 1024 * 1024 * 1024
 
 DESCRIPTIONS = {
   'CodeLoad':
       'Measures how quickly a JavaScript engine can start executing code '
       'after loading a large JavaScript program, social widget being a common '
       'example. The source for test is derived from open source libraries '
       '(Closure, jQuery) (1,530 lines).',
@@ skipping 79 matching lines @@
       # Split the results into score and test name.
       # results log e.g., "Richards: 18343"
       score_and_name = output.split(': ', 2)
       assert len(score_and_name) == 2, \
         'Unexpected result format "%s"' % score_and_name
       if 'Skipped' not in score_and_name[1]:
         name = score_and_name[0]
         score = int(score_and_name[1])
         results.AddValue(scalar.ScalarValue(
             results.current_page, name, 'score', score, important=False,
-            description=DESCRIPTIONS.get(name)))
+            description=DESCRIPTIONS.get(name),
+            improvement_direction=improvement_direction.UP))
 
         # Collect all test scores to compute geometric mean.
         all_scores.append(score)
     total = statistics.GeometricMean(all_scores)
     results.AddSummaryValue(
         scalar.ScalarValue(None, 'Total.Score', 'score', total,
                            description='Geometric mean of the scores of each '
                                        'individual benchmark in the Octane '
-                                       'benchmark collection.'))
+                                       'benchmark collection.',
+                           improvement_direction=improvement_direction.UP))
 
 
 class Octane(benchmark.Benchmark):
   """Google's Octane JavaScript benchmark.
 
   http://octane-benchmark.googlecode.com/svn/latest/index.html
   """
   test = _OctaneMeasurement
 
   def CreatePageSet(self, options):
     ps = page_set.PageSet(
       archive_data_file='../page_sets/data/octane.json',
       file_path=os.path.abspath(__file__),
       bucket=page_set.PUBLIC_BUCKET)
     ps.AddUserStory(page_module.Page(
         'http://octane-benchmark.googlecode.com/svn/latest/index.html?auto=1',
         ps, ps.base_dir, make_javascript_deterministic=False))
     return ps