Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: tools/perf/benchmarks/media.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/media.py
diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py
index a45fd5d5bc90e4f8ac2772d26f4a38664ef95da0..e42f55cc62d13b7ea21bc6d4bde91d34bee0eef2 100644
--- a/tools/perf/benchmarks/media.py
+++ b/tools/perf/benchmarks/media.py
@@ -6,6 +6,7 @@ from measurements import media
import page_sets
from telemetry import benchmark
from telemetry.page import page_test
+from telemetry.value import improvement_direction
from telemetry.value import list_of_scalar_values
from telemetry.value import scalar
@@ -25,12 +26,14 @@ class _MSEMeasurement(page_test.PageTest):
results.AddValue(list_of_scalar_values.ListOfScalarValues(
results.current_page, trace_name, units='ms',
values=[float(v) for v in metrics[m]],
- important=True))
+ important=True,
+ improvement_direction=improvement_direction.DOWN))
else:
results.AddValue(scalar.ScalarValue(
results.current_page, trace_name, units='ms',
- value=float(metrics[m]), important=True))
+ value=float(metrics[m]), important=True,
+ improvement_direction=improvement_direction.DOWN))
@benchmark.Disabled('android')

Powered by Google App Engine
This is Rietveld 408576698