Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: tools/perf/benchmarks/maps.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix linter issues Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/maps.py
diff --git a/tools/perf/benchmarks/maps.py b/tools/perf/benchmarks/maps.py
index be36d7204036552eeff75e43511d5bd9794f461e..41bb9c0d8652fba9f9fdeba50ac2d7f43d6c41db 100644
--- a/tools/perf/benchmarks/maps.py
+++ b/tools/perf/benchmarks/maps.py
@@ -13,6 +13,7 @@ from telemetry.core import util
from telemetry.page import page as page_module
from telemetry.page import page_set as page_set_module
from telemetry.page import page_test
+from telemetry.value import improvement_direction
from telemetry.value import scalar
@@ -28,9 +29,11 @@ class _MapsMeasurement(page_test.PageTest):
total = re.search('total=([0-9]+)', test_results).group(1)
render = re.search('render=([0-9.]+),([0-9.]+)', test_results).group(2)
results.AddValue(scalar.ScalarValue(
- results.current_page, 'total_time', 'ms', total))
+ results.current_page, 'total_time', 'ms', total,
+ improvement_direction=improvement_direction.DOWN))
results.AddValue(scalar.ScalarValue(
- results.current_page, 'render_mean_time', 'ms', render))
+ results.current_page, 'render_mean_time', 'ms', render,
+ improvement_direction=improvement_direction.DOWN))
class MapsPage(page_module.Page):
def __init__(self, page_set, base_dir):

Powered by Google App Engine
This is Rietveld 408576698