Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: tools/perf/benchmarks/octane.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/octane.py
diff --git a/tools/perf/benchmarks/octane.py b/tools/perf/benchmarks/octane.py
index be50c621e513a72f86dcd484f8a65513c31b1042..831c2f7bc4bb779a2871513c58e1c06bf96a9695 100644
--- a/tools/perf/benchmarks/octane.py
+++ b/tools/perf/benchmarks/octane.py
@@ -117,7 +117,7 @@ class _OctaneMeasurement(page_test.PageTest):
score = int(score_and_name[1])
results.AddValue(scalar.ScalarValue(
results.current_page, name, 'score', score, important=False,
- description=DESCRIPTIONS.get(name)))
+ description=DESCRIPTIONS.get(name), higher_is_better=True))
# Collect all test scores to compute geometric mean.
all_scores.append(score)

Powered by Google App Engine
This is Rietveld 408576698