Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/perf/benchmarks/media.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/media.py
diff --git a/tools/perf/benchmarks/media.py b/tools/perf/benchmarks/media.py
index 820fa374d75b903c481eccdddd2071a02df1874f..2d7752761d205e85c4cb9bc189dcdc8fb61945e0 100644
--- a/tools/perf/benchmarks/media.py
+++ b/tools/perf/benchmarks/media.py
@@ -21,12 +21,13 @@ class _MSEMeasurement(page_test.PageTest):
results.AddValue(list_of_scalar_values.ListOfScalarValues(
results.current_page, trace_name, units='ms',
values=[float(v) for v in metrics[m]],
- important=True))
+ important=True, higher_is_better=False))
else:
results.AddValue(scalar.ScalarValue(
results.current_page, trace_name, units='ms',
- value=float(metrics[m]), important=True))
+ value=float(metrics[m]), important=True,
+ higher_is_better=False))
@benchmark.Disabled('android')

Powered by Google App Engine
This is Rietveld 408576698