tools/perf/benchmarks/robohornet_pro.py - Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/robohornet_pro.py

Issue 809393002: Added support for improvement_direction to relevant values, which is propogated to chartjson. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/benchmarks/robohornet_pro.py

diff --git a/tools/perf/benchmarks/robohornet_pro.py b/tools/perf/benchmarks/robohornet_pro.py

index d36da24c1c7f850d03cbd0b1ef0b561a15f85235..d0ad9aa3a1c34a2925684a3b645c387c1d03f69c 100644

--- a/tools/perf/benchmarks/robohornet_pro.py

+++ b/tools/perf/benchmarks/robohornet_pro.py

@@ -39,7 +39,8 @@ class _RobohornetProMeasurement(page_test.PageTest):

result = int(tab.EvaluateJavaScript('stopTime - startTime'))

results.AddValue(

- scalar.ScalarValue(results.current_page, 'Total', 'ms', result))

+ scalar.ScalarValue(results.current_page, 'Total', 'ms', result,

+ higher_is_better=False))

# We plan to remove this test because it doesn't give useful data, but

« tools/perf/benchmarks/dom_perf.py ('K') | « tools/perf/benchmarks/octane.py ('k') | tools/perf/benchmarks/service_worker.py » ('j') | tools/telemetry/telemetry/value/__init__.py » ('J')