Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 809103002: Add NewMachPort() and its test, and switch call sites to use it (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add NewMachPort() and its test, and switch call sites to use it. There were many call sites that wasted a few lines on mach_port_allocate() and sticking the result into a scoper. I was about to add three more, so I took the opportunity to simplify things. TEST=util_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a02f721637fc0c999f83796fe80044bc912fcc1a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -48 lines) Patch
M util/mach/child_port_handshake.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M util/mach/mach_extensions.h View 1 chunk +11 lines, -0 lines 0 comments Download
M util/mach/mach_extensions.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M util/mach/mach_extensions_test.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M util/mach/mach_message_server_test.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M util/mach/notify_server_test.cc View 11 chunks +20 lines, -25 lines 0 comments Download
M util/test/mac/mach_multiprocess.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
6 years ago (2014-12-17 18:51:35 UTC) #2
Robert Sesek
https://codereview.chromium.org/809103002/diff/1/util/mach/mach_extensions.cc File util/mach/mach_extensions.cc (right): https://codereview.chromium.org/809103002/diff/1/util/mach/mach_extensions.cc#newcode32 util/mach/mach_extensions.cc:32: mach_port_t port; = MACH_PORT_NULL, and then you can just ...
6 years ago (2014-12-17 20:06:47 UTC) #3
Mark Mentovai
Updated.
6 years ago (2014-12-17 20:08:55 UTC) #4
Robert Sesek
LGTM
6 years ago (2014-12-17 20:09:21 UTC) #5
Mark Mentovai
6 years ago (2014-12-17 20:10:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a02f721637fc0c999f83796fe80044bc912fcc1a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698