Add NewMachPort() and its test, and switch call sites to use it

util/mach/mach_extensions.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/mach/mach_extensions.h"
 
 #include <AvailabilityMacros.h>
 #include <pthread.h>
 
+#include "base/mac/mach_logging.h"
 #include "util/mac/mac_util.h"
 
 namespace crashpad {
 
 thread_t MachThreadSelf() {
   // The pthreads library keeps its own copy of the thread port. Using it does
   // not increment its reference count.
   return pthread_mach_thread_np(pthread_self());
 }
 
+mach_port_t NewMachPort(mach_port_right_t right) {
+  mach_port_t port;

[Robert Sesek, 2014/12/17 20:06:47]

= MACH_PORT_NULL, and then you can just do MACH_LOG_IF and return port.

+  kern_return_t kr = mach_port_allocate(mach_task_self(), right, &port);
+  if (kr != KERN_SUCCESS) {
+    MACH_LOG(ERROR, kr) << "mach_port_allocate";
+    return MACH_PORT_NULL;
+  }
+
+  return port;
+}
+
 exception_mask_t ExcMaskAll() {
   // This is necessary because of the way that the kernel validates
   // exception_mask_t arguments to
   // {host,task,thread}_{get,set,swap}_exception_ports(). It is strict,
   // rejecting attempts to operate on any bits that it does not recognize. See
   // 10.9.4 xnu-2422.110.17/osfmk/mach/ipc_host.c and
   // xnu-2422.110.17/osfmk/mach/ipc_tt.c.
 
 #if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_9
   int mac_os_x_minor_version = MacOSXMinorVersion();
@@ skipping 22 matching lines @@
   }
 #endif
 
   // 10.9 added EXC_MASK_GUARD. See 10.9.4
   // xnu-2422.110.17/osfmk/mach/exception_types.h.
   const exception_mask_t kExcMaskAll_10_9 = kExcMaskAll_10_8 | EXC_MASK_GUARD;
   return kExcMaskAll_10_9;
 }
 
 }  // namespace crashpad