Add NewMachPort() and its test, and switch call sites to use it

util/mach/mach_message_server_test.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 447 matching lines @@
         request.header.msgh_local_port = LocalPort();
         break;
       case Options::kReplyPortNull:
         request.header.msgh_local_port = MACH_PORT_NULL;
         break;
       case Options::kReplyPortDead: {
         // Use a newly-allocated receive right that will be destroyed when this
         // method returns. A send right will be made from this receive right and
         // carried in the request message to the server. By the time the server
         // looks at the right, it will have become a dead name.
-        kr = mach_port_allocate(mach_task_self(),
-                                MACH_PORT_RIGHT_RECEIVE,
-                                &request.header.msgh_local_port);
-        ASSERT_EQ(KERN_SUCCESS, kr)
-            << MachErrorMessage(kr, "mach_port_allocate");
-        local_receive_port_owner.reset(request.header.msgh_local_port);
+        local_receive_port_owner.reset(NewMachPort(MACH_PORT_RIGHT_RECEIVE));
+        ASSERT_NE(kMachPortNull, local_receive_port_owner);
+        request.header.msgh_local_port = local_receive_port_owner;
         break;
       }
     }
     request.header.msgh_id = kRequestMessageID;
     if (options_.client_send_complex) {
       // Allocate a new receive right in this process and make a send right that
       // will appear in the parent process. This is used to test that the server
       // properly handles ownership of resources received in complex messages.
       request.body.msgh_descriptor_count = 1;
-      kr = mach_port_allocate(mach_task_self(),
-                              MACH_PORT_RIGHT_RECEIVE,
-                              &request.port_descriptor.name);
-      ASSERT_EQ(KERN_SUCCESS, kr)
-          << MachErrorMessage(kr, "mach_port_allocate");
-      child_complex_message_port_.reset(request.port_descriptor.name);
+      child_complex_message_port_.reset(NewMachPort(MACH_PORT_RIGHT_RECEIVE));
+      ASSERT_NE(kMachPortNull, child_complex_message_port_);
+      request.port_descriptor.name = child_complex_message_port_;
       request.port_descriptor.disposition = MACH_MSG_TYPE_MAKE_SEND;
       request.port_descriptor.type = MACH_MSG_PORT_DESCRIPTOR;
     } else {
       request.body.msgh_descriptor_count = 0;
       request.port_descriptor.name = MACH_PORT_NULL;
       request.port_descriptor.disposition = 0;
       request.port_descriptor.type = 0;
     }
     request.ndr = NDR_record;
     request.number = requests_++;
@@ skipping 351 matching lines @@
   options.expect_server_transaction_count = 0;
   options.client_send_large = true;
   options.client_expect_reply = false;
   TestMachMessageServer test_mach_message_server(options);
   test_mach_message_server.Test();
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace crashpad