Issue 808673005: Member<T>::IteratorConstReferenceType should be const Blink::Member<T>&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 808673005: Member<T>::IteratorConstReferenceType should be const Blink::Member<T>&. (Closed)

Created:
6 years ago by tasak

Modified:
6 years ago

Reviewers:
haraken, sof

CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Member<T>::IteratorConstReferenceType should be const Blink::Member<T>&. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187231

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	Source/platform/heap/Handle.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/808673005/1

6 years ago (2014-12-16 06:02:08 UTC) #5

sof

Could you supply some more detail on the description about why having a boxed Member<> ...

6 years ago (2014-12-16 06:27:12 UTC) #7

commit-bot: I haz the power

6 years ago (2014-12-16 07:13:07 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187231