Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2100)

Unified Diff: Source/platform/heap/Handle.h

Issue 808673005: Member<T>::IteratorConstReferenceType should be const Blink::Member<T>&. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Handle.h
diff --git a/Source/platform/heap/Handle.h b/Source/platform/heap/Handle.h
index 2113277b8b853668dffb3c9f6d73446d5dbff4c9..b0b0480b263f85d67af8801eb3d676a64cc53227 100644
--- a/Source/platform/heap/Handle.h
+++ b/Source/platform/heap/Handle.h
@@ -1050,9 +1050,9 @@ template<typename T> struct HashTraits<blink::Member<T>> : SimpleClassHashTraits
using IteratorGetType = blink::Member<T>*;
using IteratorConstGetType = const blink::Member<T>*;
using IteratorReferenceType = blink::Member<T>&;
- using IteratorConstReferenceType = T* const;
+ using IteratorConstReferenceType = const blink::Member<T>&;
static IteratorReferenceType getToReferenceConversion(IteratorGetType x) { return *x; }
- static IteratorConstReferenceType getToReferenceConstConversion(IteratorConstGetType x) { return x->get(); }
+ static IteratorConstReferenceType getToReferenceConstConversion(IteratorConstGetType x) { return *x; }
// FIXME: Similarly, there is no need for a distinction between PeekOutType
// and PassOutType without reference counting.
using PeekOutType = T*;
@@ -1077,9 +1077,9 @@ template<typename T> struct HashTraits<blink::WeakMember<T>> : SimpleClassHashTr
using IteratorGetType = blink::WeakMember<T>*;
using IteratorConstGetType = const blink::WeakMember<T>*;
using IteratorReferenceType = blink::WeakMember<T>&;
- using IteratorConstReferenceType = T* const;
+ using IteratorConstReferenceType = const blink::WeakMember<T>&;
static IteratorReferenceType getToReferenceConversion(IteratorGetType x) { return *x; }
- static IteratorConstReferenceType getToReferenceConstConversion(IteratorConstGetType x) { return x->get(); }
+ static IteratorConstReferenceType getToReferenceConstConversion(IteratorConstGetType x) { return *x; }
// FIXME: Similarly, there is no need for a distinction between PeekOutType
// and PassOutType without reference counting.
using PeekOutType = T*;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698