Windows run-webkit-tests broke if --disable-breakpad was used

Windows run-webkit-tests broke if --disable-breakpad was used

Running run-webkit-tests in Windows with --disable-breakpad resulted in

AttributeError raised: 'WinPort' object has no attribute '_crash_service'
Traceback (most recent call last):
  File "src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 73, in main
    run_details = run(port, options, args, stderr)
  File "src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 381, in run
    run_details = manager.run(args)
  File "src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\controllers\manager.py", line 278, in run
    self._clean_up_run()
  File "src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\controllers\manager.py", line 359, in _clean_up_run
    self._port.clean_up_test_run()
  File "L:\src\clean_chromium\src\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\port\win.py", line 150, in clean_up_test_run
    if self._crash_service:

R=dpranke@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187488

[Daniel Bratell, 2014-12-17 16:19:51]

Patchset #1 (id:1) has been deleted

[Daniel Bratell, 2014-12-17 16:21:30]

bratell@opera.com changed reviewers:
+ dpranke@chromium.org

[Daniel Bratell, 2014-12-17 16:21:34]

dpranke, can you take a look at this one-liner? I don't know if it's a correct
fix or just a minimal fix.

[Dirk Pranke, 2014-12-17 22:04:47]

lgtm w/ minor change, below.

https://codereview.chromium.org/808163002/diff/20001/Tools/Scripts/webkitpy/l...
File Tools/Scripts/webkitpy/layout_tests/port/win.py (right):

https://codereview.chromium.org/808163002/diff/20001/Tools/Scripts/webkitpy/l...
Tools/Scripts/webkitpy/layout_tests/port/win.py:82: self._crash_service = None
ick, it's bad to have member fields that only conditionally exist; thanks for
fixing this!

We should actually make sure that all of the fields exist, so I would pull the
_crash_service_available field out of the conditional as well.

[Daniel Bratell, 2014-12-18 16:51:41]

https://codereview.chromium.org/808163002/diff/20001/Tools/Scripts/webkitpy/l...
File Tools/Scripts/webkitpy/layout_tests/port/win.py (right):

https://codereview.chromium.org/808163002/diff/20001/Tools/Scripts/webkitpy/l...
Tools/Scripts/webkitpy/layout_tests/port/win.py:82: self._crash_service = None
On 2014/12/17 22:04:47, Dirk Pranke wrote:
> ick, it's bad to have member fields that only conditionally exist; thanks for
> fixing this!
> 
> We should actually make sure that all of the fields exist, so I would pull the
> _crash_service_available field out of the conditional as well.
> 

Done.

[Daniel Bratell, 2014-12-18 16:57:43]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-12-18 16:58:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/808163002/40001

[commit-bot: I haz the power, 2014-12-18 19:52:55]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187488