Windows run-webkit-tests broke if --disable-breakpad was used

Tools/Scripts/webkitpy/layout_tests/port/win.py

 # Copyright (C) 2010 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 60 matching lines @@
                 version = host.platform.os_version
             port_name = port_name + '-' + version
         return port_name
 
     def __init__(self, host, port_name, **kwargs):
         super(WinPort, self).__init__(host, port_name, **kwargs)
         self._version = port_name[port_name.index('win-') + len('win-'):]
         assert self._version in self.SUPPORTED_VERSIONS, "%s is not in %s" % (self._version, self.SUPPORTED_VERSIONS)
         if not self.get_option('disable_breakpad'):
             self._dump_reader = DumpReaderWin(host, self._build_path())
-            self._crash_service = None
             self._crash_service_available = None
+        self._crash_service = None

[Dirk Pranke, 2014/12/17 22:04:47]

ick, it's bad to have member fields that only conditionally exist; thanks for
fixing this!

We should actually make sure that all of the fields exist, so I would pull the
_crash_service_available field out of the conditional as well.

[Daniel Bratell, 2014/12/18 16:51:41]

Done.

 
     def additional_drt_flag(self):
         flags = super(WinPort, self).additional_drt_flag()
         flags += ['--enable-direct-write']
         if not self.get_option('disable_breakpad'):
             flags += ['--enable-crash-reporter', '--crash-dumps-dir=%s' % self._dump_reader.crash_dumps_directory()]
         return flags
 
     def check_httpd(self):
         res = super(WinPort, self).check_httpd()
@@ skipping 144 matching lines @@
         return result
 
     def look_for_new_crash_logs(self, crashed_processes, start_time):
         if self.get_option('disable_breakpad'):
             return None
         return self._dump_reader.look_for_new_crash_logs(crashed_processes, start_time)
 
     def clobber_old_port_specific_results(self):
         if not self.get_option('disable_breakpad'):
             self._dump_reader.clobber_old_results()